Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 4:40 p.m.) Review request for mesos, Alexander

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 6:55 p.m.) Review request for mesos, Alexander

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

> On Jan. 19, 2016, 5:23 p.m., Alexander Rukletsov wrote: > > Let's tweak some wording and testing and we are good to go! > > > > I liked the initial summary more. IMO a patch should describe the solution, > > and not the problem. It's quite opposite for JIRA tickets, hence I'm > > convinced

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 7:10 p.m.) Review request for mesos, Alexander

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115142 --- It would be great if you add a comment describing the cluster

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115143 --- src/tests/hierarchical_allocator_tests.cpp (lines 1812 - 1824)

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 8:03 p.m.) Review request for mesos, Alexander

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115264 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 19, 2016, 2:25

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115270 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 19, 2016,

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- (Updated Jan. 19, 2016, 10:25 p.m.) Review request for mesos, Alexander

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

> On Jan. 19, 2016, 7:53 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 1817-1829 > > > > > > What about make the test cases cover both `addSlave()` before and after > >

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

> On 一月 19, 2016, 11:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 1817-1829 > > > > > > What about make the test cases cover both `addSlave()` before and after > >

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

> On 一月 19, 2016, 11:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 1817-1829 > > > > > > What about make the test cases cover both `addSlave()` before and after > >

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115156 --- src/master/allocator/mesos/hierarchical.cpp (line 1229)

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

> On Jan. 19, 2016, 11:53 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 1817-1829 > > > > > > What about make the test cases cover both `addSlave()` before and after > >

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

> On Jan. 19, 2016, 2:38 p.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1229 > > > > > > s/those visible in the current / those agents provided via `slaveIDs` > > to the `allocate`

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review114908 --- Ping @alex-mesos/@jvanremoortere, any comments. - Klaus Ma On

Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/ --- Review request for mesos, Alexander Rukletsov and Neil Conway. Bugs:

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review114465 --- Patch looks great! Reviews applied: [42289] Passed command: