Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-02-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 3, 2016, 12:43 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-02-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117534 --- Fix it, then Ship it!

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-02-02 Thread Avinash sridharan
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 65-75 > > > > > > Why do we need this? Was using this data structure to pass on the usage of handles

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-02-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 2, 2016, 5:52 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-02-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117225 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-02-01 Thread Guangya Liu
> On 二月 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 40 > > > > > > 2 blank lines above please. Does there are any policies for this when need one blank

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-01-31 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Jan. 31, 2016, 5:45 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-01-31 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117171 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-01-31 Thread Avinash sridharan
> On Feb. 1, 2016, 1:46 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 44 > > > > > > s/issue/issues Thanks for catching this. - Avinash

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-01-31 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 1, 2016, 2:20 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42586: Defined the NetClsHandleMgr class.

2016-01-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Jan. 26, 2016, 6:11 a.m.) Review request for mesos and Jie Yu.