Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-05 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 5, 2016, 10:24 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-05 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 5, 2016, 3:31 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-05 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 5, 2016, 3:27 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-05 Thread Avinash sridharan
> On Feb. 5, 2016, 12:31 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 200 > > > > > > What's defaultPrimary? Who is the user? Can you just do the following: > > > >

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review118133 --- Ship it! Ship It! - Jie Yu On Feb. 5, 2016, 10:24 p.m.,

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review118122 --- Patch looks great! Reviews applied: [42982, 42983, 43096, 42618]

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117916 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 4, 2016, 1:42 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117646 --- src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-02 Thread Avinash sridharan
> On Feb. 1, 2016, 8:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 440-443 > > > > > > Can you try to see if writing a decimal number if fine as well? If not, > > we

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 2, 2016, 6:32 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 3, 2016, 12:48 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

2016-02-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Feb. 3, 2016, 7:46 a.m.) Review request for mesos and Jie Yu. Bugs: