Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-07-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/ --- (Updated July 12, 2016, 2:33 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-03-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/ --- (Updated March 3, 2016, 1 p.m.) Review request for mesos and Ben Mahler. Chan

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-11 Thread Guangya Liu
> On 二月 4, 2016, 3:46 p.m., Guangya Liu wrote: > > This case may happen when master is recovering, framework recovery start > > before some agent. Can you please add a unit test to cover this code > > change? It could be register framework first, then addslave and check the > > result. > > Al

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-10 Thread Alexander Rukletsov
> On Feb. 4, 2016, 3:46 p.m., Guangya Liu wrote: > > This case may happen when master is recovering, framework recovery start > > before some agent. Can you please add a unit test to cover this code > > change? It could be register framework first, then addslave and check the > > result. > >

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-05 Thread Guangya Liu
> On 二月 4, 2016, 3:46 p.m., Guangya Liu wrote: > > This case may happen when master is recovering, framework recovery start > > before some agent. Can you please add a unit test to cover this code > > change? It could be register framework first, then addslave and check the > > result. > > Al

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-04 Thread Alexander Rukletsov
> On Feb. 4, 2016, 3:46 p.m., Guangya Liu wrote: > > This case may happen when master is recovering, framework recovery start > > before some agent. Can you please add a unit test to cover this code > > change? It could be register framework first, then addslave and check the > > result. Nope

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/#review117822 --- This case may happen when master is recovering, framework recovery

Re: Review Request 43105: Ensured the allocator does not double account resources.

2016-02-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/#review117542 --- Patch looks great! Reviews applied: [42633, 42636, 42657, 42658,

Review Request 43105: Ensured the allocator does not double account resources.

2016-02-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43105/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --