Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 25, 2016, 5:15 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-25 Thread Alex Clemmer
> On Feb. 25, 2016, 12:09 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp, lines > > 73-74 > > > > > > We're only testing that `loadSymbol` fails if we don't call `open

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review120616 --- Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/tests

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review119929 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m.

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 18, 2016, 12:59 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-11 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review118908 --- Ship it! Ship It! - M Lawindi On Feb. 10, 2016, 6:47 a.m., A

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-11 Thread Daniel Pravat
> On Feb. 11, 2016, 6 p.m., Daniel Pravat wrote: > > Ship It! RB diff is showing a more complicated picture. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review118889 -

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review118889 --- Ship it! Ship It! - Daniel Pravat On Feb. 10, 2016, 6:47 a.m

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-10 Thread Alex Clemmer
> On Feb. 10, 2016, 11:50 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43407, 43409, 43410] > > > > Failed command: ./support/apply-review.sh -n -r 43410 > > > > Error: > > 2016-02-10 11:49:59 URL:https://reviews.apache.org/r/43410/diff/raw/ > > [8010/8010] -> "43410.

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review118629 --- Bad patch! Reviews applied: [43407, 43409, 43410] Failed command

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 10, 2016, 6:47 a.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 10, 2016, 6:44 a.m.) Review request for mesos, Alex Naparu, Danie

Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V