Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review124937 --- Fix it, then Ship it! Thanks! Just some minor adjustments I'll

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 15, 2016, 3:51 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review122170 --- Ship it! Ship It! - Alexander Rojas On March 3, 2016, 5:17

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review122043 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2016,

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, line 872 > > > > > > s/the allocator was triggered/allocation was performed. > > > > Technically, we trigger allocator when

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121856 --- docs/monitoring.md (line 872)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 3, 2016, 2:12 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, lines 872-874 > > > > > > Why not putting these onto the same line? > > Benjamin Bannier wrote: > Let's keep consistent

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121639 --- src/master/allocator/mesos/metrics.hpp (line 46)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 1, 2016, 11:48 a.m., Alexander Rukletsov wrote: > > docs/monitoring.md, lines 872-874 > > > > > > Why not putting these onto the same line? > > Benjamin Bannier wrote: > Let's keep consistent

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120985 --- On March 2, 2016, 11:35 a.m., Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 27, 2016, 12:13 a.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2395 > > > > > > Not yours but we don't start function names with a capital letter and > > that threw me

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121255 --- On March 2, 2016, 11:35 a.m., Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2391 > > > > > > This looks like a creation of an instance of some `Metrics` class. > > Let's rename

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated March 2, 2016, 11:35 a.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121255 --- docs/monitoring.md (lines 859 - 862)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 26, 2016, 6:03 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120570 --- On Feb. 24, 2016, 9:42 p.m., Benjamin Bannier wrote:

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 9:42 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 9:17 p.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2395-2398 > > > > > > Why isn't it an `AWAIT_READY` macro? you still use an `AWAIT_*` > > afterwards, so

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120570 --- src/tests/hierarchical_allocator_tests.cpp (lines 2395 - 2398)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 8:25 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 4:21 p.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2385 > > > > > > Why a anonymous namespace? `static` should be fine. In C `static` has more usages than just

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120507 --- src/tests/hierarchical_allocator_tests.cpp (line 2385)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 2:06 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2398 > > > > > > I saw that most are using `Seconds(15)` > > Guangya Liu wrote: > Can you please clarify

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 2:06 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2398 > > > > > > I saw that most are using `Seconds(15)` > > Guangya Liu wrote: > Can you please clarify

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On 二月 24, 2016, 1:06 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2398 > > > > > > I saw that most are using `Seconds(15)` Can you please clarify why using `Seconds{15}` but not

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 2:25 p.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120492 --- src/master/allocator/mesos/hierarchical.hpp (lines 25 - 26)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 11:22 a.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On 二月 24, 2016, 1:50 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 286 > > > > > > some comments here > > Benjamin Bannier wrote: > For variables which such narrow usage I

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120473 --- src/master/allocator/mesos/hierarchical.cpp (line 1156)

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 24, 2016, 9:46 a.m.) Review request for mesos, Alexander

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On Feb. 24, 2016, 2:50 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 286 > > > > > > some comments here For variables which such narrow usage I would prefer to give them a

Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4718