Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review124562 --- Patch looks great! Reviews applied: [44850, 44851, 44852, 43884,

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander Ruklet

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review123696 --- Patch looks great! Reviews applied: [44850, 44851, 44852, 43884,

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 15, 2016, 3:52 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

> On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 288-297 > > > > > > I suggest we create a helper in `Metrics` for this. Also, minor nit: in > > previ

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 4, 2016, 5:01 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review122056 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 3, 2016, 2:12 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

> On March 1, 2016, 12:56 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 276-282 > > > > > > As in previous reviews, let's go for: > > > > ```c++ > > metrics.framewor

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander Ruklets