> On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 288-297 > > <https://reviews.apache.org/r/43883/diff/13/?file=1279215#file1279215line288> > > > > I suggest we create a helper in `Metrics` for this. Also, minor nit: in > > previous patches you didn't separate `.put()` from > > `process::metrics::add()` with a blank line.
I introduced a number of helpers in the latest incarnation of this series, among others this one. Blank lines should be consistent now. > On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 293 > > <https://reviews.apache.org/r/43883/diff/13/?file=1279215#file1279215line293> > > > > I believe this one requires `->self()` as well. Code got moved to helper, and adjusted there. > On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 368-369 > > <https://reviews.apache.org/r/43883/diff/13/?file=1279215#file1279215line368> > > > > Same here. Done. > On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 538 > > <https://reviews.apache.org/r/43883/diff/13/?file=1279218#file1279218line538> > > > > Why do explicitly use double `0` here? I thought you rely on implicit > > conversions and promotions in these patches. This was a simple oversight, fixed now. > On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2462-2466 > > <https://reviews.apache.org/r/43883/diff/13/?file=1279218#file1279218line2462> > > > > Here you can also check that 2 counters for offers filters were > > installed. We do now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review122056 ----------------------------------------------------------- On March 4, 2016, 5:01 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43883/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 5:01 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4722 > https://issues.apache.org/jira/browse/MESOS-4722 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 70291075c00a9a557529c2562dedcfc6c6c3ec32 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > src/tests/hierarchical_allocator_tests.cpp > 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 > > Diff: https://reviews.apache.org/r/43883/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
