Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

2016-03-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121672 --- Ship it! Ship It! - Anand Mazumdar On March 2, 2016, 1:09

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

2016-03-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/ --- (Updated March 2, 2016, 1:09 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

2016-03-01 Thread Vinod Kone
> On March 1, 2016, 10:32 p.m., Anand Mazumdar wrote: > > src/internal/devolve.cpp, line 123 > > > > > > Nit: s/but `Call::Subscribe` has// > > > > Since we are inside `devolve` for conversion to

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

2016-03-01 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121535 --- Ship it! Ship It! - Greg Mann On March 1, 2016, 7:47 p.m.,

Re: Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

2016-03-01 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/#review121516 --- Fix it, then Ship it! LGTM. src/internal/devolve.cpp (line

Review Request 44218: Removed 'Subscribe.force' field from v1 Scheduler API.

2016-03-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44218/ --- Review request for mesos, Anand Mazumdar and Greg Mann. Bugs: MESOS-4712