Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review130504 --- Ship it! Thanks for the comment! I've added a commit

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On April 11, 2016, 10:09 p.m., Klaus Ma wrote: > > Ship It! > > Klaus Ma wrote: > LGTM. Just wonder how to handle the input that did not follow our > expectation: > > // value,event,cgroup > // value,unit,event,cgroup > //

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review129299 --- Patch looks great! Reviews applied: [44379] Passed command:

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ --- (Updated 四月 18, 2016, 5:41 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On 四月 11, 2016, 2:09 p.m., Klaus Ma wrote: > > Ship It! > > Klaus Ma wrote: > LGTM. Just wonder how to handle the input that did not follow our > expectation: > > // value,event,cgroup > // value,unit,event,cgroup > // value,unit,event,cgroup,running,ratio

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On April 16, 2016, 12:23 p.m., haosdent huang wrote: > > src/linux/perf.cpp, line 346 > > > > > > Hi, @fan.du. I believe @bmahler would like to elaborate more details > > here. Just my idea, feel free to correct

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review129245 --- src/linux/perf.cpp (line 346)

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On April 11, 2016, 7:08 a.m., haosdent huang wrote: > > Thanks you very much for your quick reply! By the way, this patch should > > credited by you, please update the description and remove my name. Quite > > appreciated your great help again so that I could rebase my patches depend > > on

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On April 11, 2016, 10:09 p.m., Klaus Ma wrote: > > Ship It! LGTM. Just wonder how to handle the input that did not follow our expectation: // value,event,cgroup // value,unit,event,cgroup // value,unit,event,cgroup,running,ratio - Klaus

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review128117 --- Ship it! Ship It! - Klaus Ma On April 11, 2016, 3:01 p.m.,

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review128094 --- Patch looks great! Reviews applied: [44379] Passed command:

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review128076 --- Ship it! Thanks you very much for your quick reply! By the

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ --- (Updated 四月 11, 2016, 7:01 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/ --- (Updated 四月 11, 2016, 6:57 a.m.) Review request for mesos and Ben Mahler.