Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review124039 --- Ship it! Ship It! - Michael Park On March 10, 2016, 9:59 p.m

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review123054 --- Patch looks great! Reviews applied: [44675] Passed command: expo

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/ --- (Updated March 10, 2016, 9:59 p.m.) Review request for mesos, Michael Park, Vin

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
> On March 10, 2016, 9:32 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234 > > > > > > (1) Why not just `snapshot`? > > (2) We don't use default capture by reference. Could you

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
> On March 10, 2016, 9:32 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 234 > > > > > > (1) Why not just `snapshot`? > > (2) We don't use default capture by reference. Could you

Re: Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/#review122996 --- 3rdparty/libprocess/src/metrics/metrics.cpp (line 234)

Review Request 44675: Updated `/metrics/snapshot` endpoint to use `jsonify`.

2016-03-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44675/ --- Review request for mesos, Michael Park, Vinod Kone, and Jiang Yan Xu. Bugs: MES