Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Feb. 3, 2017, 10:01 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Feb. 1, 2017, 10:45 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Jan. 31, 2017, 5:58 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Jan. 26, 2017, 10:06 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Dec. 19, 2016, 12:01 a.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, lines 244-248 > > > > > > Good find. However I think the fix would be cleaner if we just update > > the

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Jan. 25, 2017, 5:27 p.m., Jiang Yan Xu wrote: > > Just a minor comment plus the reply to a previous comment. This can go in before /r/55359/ since that is a refactor. - Jiang Yan --- This is an automatically generated e-mail. To

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review163070 --- Fix it, then Ship it! Just a minor comment plus the reply to a

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Jan. 9, 2017, 10:37 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Dec. 19, 2016, 8:01 a.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, lines 244-248 > > > > > > Good find. However I think the fix would be cleaner if we just update > > the state

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 19, 2016, 7:24 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review159590 --- Fix it, then Ship it! Otherwise it looks good. I am just going

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 12, 2016, 10:35 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 12, 2016, 9:15 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review157765 --- Ship it! I can take care of the addressing remaining minor

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 2, 2016, 9:43 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 2, 2016, 12:02 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 18, 2016, 11:56 a.m., Gastón Kleiman wrote: > > src/examples/persistent_volume_framework.cpp, line 150 > > > > > > Would it make sense to add the `shared-vol` prefix to the shard name in > > order to

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Dec. 1, 2016, 9:29 p.m., Greg Mann wrote: > > src/examples/persistent_volume_framework.cpp, lines 427-430 > > > > > > Could you provide comments here or elsewhere which give a high-level > > overview of the

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Dec. 1, 2016, 10:38 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Dec. 1, 2016, 9:29 p.m., Greg Mann wrote: > > src/examples/persistent_volume_framework.cpp, lines 502-508 > > > > > > I would suggest that we should run this test framework in the test > > suite with both

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review157642 --- Fix it, then Ship it!

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review157436 --- Fix it, then Ship it! Looks good! :)

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 17, 2016, 9:20 a.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, line 201 > > > > > > Consolidate this with `case Shard::STAGING`? > > > > We can just do: > > > >

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Nov. 29, 2016, 12:25 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Nov. 21, 2016, 8:11 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156293 --- src/examples/persistent_volume_framework.cpp (line 150)

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156292 --- src/examples/persistent_volume_framework.cpp (line 265)

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 17, 2016, 5:20 p.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, line 201 > > > > > > Consolidate this with `case Shard::STAGING`? > > > > We can just do: > > > >

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Nov. 18, 2016, 5:13 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 6, 2016, 9:25 p.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, lines 470-476 > > > > > > I think it's sufficient to have the following states. (We should use a > > minimun

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 6, 2016, 9:25 p.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, lines 470-476 > > > > > > I think it's sufficient to have the following states. (We should use a > > minimun

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156082 --- src/examples/persistent_volume_framework.cpp (lines 33 - 37)

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Nov. 8, 2016, 5:50 a.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

> On Nov. 7, 2016, 5:25 a.m., Jiang Yan Xu wrote: > > src/examples/persistent_volume_framework.cpp, line 129 > > > > > > Keep the name? > > > > Shared persistent volume is a kind of persistent volume.

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review154380 --- src/examples/persistent_volume_framework.cpp

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Oct. 21, 2016, 6:52 p.m.) Review request for mesos and Jiang Yan Xu.