Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

2016-04-14 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46116/ --- (Updated April 15, 2016, 12:11 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

2016-04-14 Thread Anand Mazumdar
> On April 13, 2016, 10:05 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > Also, I'm wondering if it would be better for the library to take > Authorization string as a parameter instead of Credential. That way it is > more generic because the library can just set "Authorization: >

Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

2016-04-13 Thread Vinod Kone
> On April 13, 2016, 10:05 p.m., Vinod Kone wrote: > > Also, I'm wondering if it would be better for the library to take Authorization string as a parameter instead of Credential. That way it is more generic because the library can just set "Authorization: ". The idea is that scheduler will

Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

2016-04-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46116/#review128764 --- Fix it, then Ship it! include/mesos/v1/scheduler.hpp (line

Review Request 46116: Added basic authentication scheme to the scheduler library.

2016-04-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46116/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4459