Re: Review Request 46191: Stout: Implemented `uname` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/ --- (Updated April 17, 2016, 10:46 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

> On April 15, 2016, 10:56 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 66 > > > > > > `std::unique_ptr` semantically means that it's pointing to a single > >

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/#review129199 --- Fix it, then Ship it!

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

> On April 14, 2016, 9:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 310 > > > > > > Please use a C++ cast. > > Alex Clemmer wrote: > I don't really know

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

> On April 14, 2016, 9:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines > > 355-360 > > > > > > If we pull out `internal::os_version`, we could do less work

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

> On April 14, 2016, 9:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines > > 355-360 > > > > > > If we pull out `internal::os_version`, we could do less work

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/ --- (Updated April 15, 2016, 8:42 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46191: Stout: Implemented `uname` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/#review129003 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Review Request 46191: Stout: Implemented `uname` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46191/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris