Re: Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

2016-05-31 Thread Joris Van Remoortere
> On May 30, 2016, 9:46 a.m., Guangya Liu wrote: > > src/messages/messages.proto, line 292 > > > > > > Why updating here, the Event here should still be `Rescind`? Thanks for catching this. We considered clarifying

Re: Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

2016-05-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46757/#review135487 --- src/messages/messages.proto (line 292)

Re: Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

2016-04-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46757/#review131175 --- Ship it! LGTM! - Joseph Wu On April 27, 2016, 6:21 p.m., Jor

Re: Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

2016-04-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46757/#review130972 --- src/messages/messages.proto (line 304)

Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

2016-04-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46757/ --- Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone. Bugs: MESO