Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-24 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/ --- (Updated June 24, 2016, 4:05 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review139175 --- Ship it! Ship It! - haosdent huang On June 22, 2016, 6:19

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-22 Thread Vinod Kone
> On June 21, 2016, 12:36 a.m., Vinod Kone wrote: > > src/CMakeLists.txt, line 24 > > > > > > don't you need to change this? > > Zhitao Li wrote: > I'd like to address this in a separate patch, and I have some

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review139117 --- Ship it! Ship It! - Vinod Kone On June 22, 2016, 6:19 p.m.,

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-22 Thread Zhitao Li
> On June 21, 2016, 12:36 a.m., Vinod Kone wrote: > > src/CMakeLists.txt, line 24 > > > > > > don't you need to change this? I'd like to address this in a separate patch, and I have some open question on how to

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread Vinod Kone
> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote: > > To avoid confusion, we should actually change the namespace allocator code > > lives is as well. I've once started that effort > > (https://reviews.apache.org/r/29930/) but decided to discard because > > allocator is the

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138709 --- src/CMakeLists.txt (line 24)

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread Alexander Rukletsov
> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote: > > To avoid confusion, we should actually change the namespace allocator code > > lives is as well. I've once started that effort > > (https://reviews.apache.org/r/29930/) but decided to discard because > > allocator is the

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread haosdent huang
> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote: > > To avoid confusion, we should actually change the namespace allocator code > > lives is as well. I've once started that effort > > (https://reviews.apache.org/r/29930/) but decided to discard because > > allocator is the

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread Zhitao Li
> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote: > > To avoid confusion, we should actually change the namespace allocator code > > lives is as well. I've once started that effort > > (https://reviews.apache.org/r/29930/) but decided to discard because > > allocator is the

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread haosdent huang
> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote: > > To avoid confusion, we should actually change the namespace allocator code > > lives is as well. I've once started that effort > > (https://reviews.apache.org/r/29930/) but decided to discard because > > allocator is the

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread Zhitao Li
> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote: > > To avoid confusion, we should actually change the namespace allocator code > > lives is as well. I've once started that effort > > (https://reviews.apache.org/r/29930/) but decided to discard because > > allocator is the

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138546 --- To avoid confusion, we should actually change the namespace

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138395 --- include/mesos/v1/maintenance/maintenance.proto (line 18)

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138393 --- Patch looks great! Reviews applied: [48902] Passed command:

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138389 --- I think we need move `master/allocator.proto` to

Review Request 48902: Move v1/master/allocator.proto to its own package.

2016-06-18 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Summary (updated)