Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

> On June 27, 2016, 11:21 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 1440 > > > > > > don't we need to validate the resources like we do at #1592? Posted a patch for that :

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139694 --- src/master/http.cpp (line 1440)

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139652 --- Ship it! Ship It! - Anand Mazumdar On June 27, 2016, 8:36

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- (Updated June 27, 2016, 8:36 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- (Updated June 27, 2016, 8:18 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139602 --- Fix it, then Ship it! LGTM minus a few suggested minor

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/master/http.cpp, lines 1505-1506 > > > > > > Do we need this explicit check here? I can understand why we > > introduced/need it in `GET_LEADER` but

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- (Updated June 27, 2016, 8:19 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, lines 567-568 > > > > > > Do we need the explicit `static_cast` here? Why doesn't `CopyFrom()` > > work directly? Did not quite

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/master/http.cpp, lines 1505-1506 > > > > > > Do we need this explicit check here? I can understand why we > > introduced/need it in `GET_LEADER` but

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139506 --- src/master/http.cpp (lines 1505 - 1506)

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- (Updated June 25, 2016, 6:52 a.m.) Review request for mesos, Anand Mazumdar

Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/ --- Review request for mesos. Repository: mesos Description --- Implemented