Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-07-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/ --- (Updated July 4, 2016, 4:17 p.m.) Review request for mesos, Adam B, Albert Stra

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/ --- (Updated July 1, 2016, 12:49 a.m.) Review request for mesos, Adam B, Albert Str

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/ --- (Updated June 30, 2016, 8:01 p.m.) Review request for mesos, Adam B, Albert Str

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
> On June 30, 2016, 2:51 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp, lines 240-243 > > > > > > I'm not sure I understand why this works. > > `in_addr.get().s_addr` is a uint.

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
> On June 30, 2016, 3:24 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp, line 237 > > > > > > I am not sure if this is a C-ism, but calling the variable like the > > `struct` and then ha

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/#review140171 --- Fix it, then Ship it! 3rdparty/libprocess/src/ssl/utilities.cp

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Till Toenshoff
> On June 30, 2016, 2:51 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp, lines 240-243 > > > > > > I'm not sure I understand why this works. > > `in_addr.get().s_addr` is a uint.

Re: Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/#review140164 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/ssl/

Review Request 49400: Extended utilities to render certificate extension for IP.

2016-06-29 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/ --- Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris Van