Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-24 Thread Benjamin Mahler
> On Aug. 24, 2016, 10:04 p.m., Benjamin Mahler wrote: > > Ship It! Note that the change isn't C++11 related (my TODO was suggesting to use a lambda which requires C++11, but your change just uses defer. Since this didn't use to work, I updated the commit summary to be the following: ```

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/#review146720 --- Ship it! Ship It! - Benjamin Mahler On Aug. 5, 2016, 3:30

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-08 Thread Gastón Kleiman
> On Aug. 8, 2016, 6:45 a.m., Benjamin Mahler wrote: > > Which compilers did you test with? I tested with: `gcc 4.8.1, 4.8.4, 4.8.5, 4.9.2, 5.3.1` `clang 7.0.2` - Gastón --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-08 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/#review145061 --- Which compilers did you test with? - Benjamin Mahler On Aug.

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/#review144974 --- Patch looks great! Reviews applied: [50853] Passed command:

Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-05 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository: