Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-18 Thread Zhitao Li
> On Oct. 18, 2016, 4:49 a.m., Jie Yu wrote: > > src/docker/docker.hpp, line 51 > > > > > > Having this as a global knob sounds really weird to me. I know you want > > to work around the Docker::run GMock issue. But

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-18 Thread haosdent huang
> On Oct. 18, 2016, 4:49 a.m., Jie Yu wrote: > > src/docker/docker.hpp, line 51 > > > > > > Having this as a global knob sounds really weird to me. I know you want > > to work around the Docker::run GMock issue. But

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review153030 --- src/docker/docker.hpp (line 51)

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review152415 --- Patch looks great! Reviews applied: [51052] Passed command: expo

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-12 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Oct. 12, 2016, 5:02 p.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-09-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review151001 --- Patch looks great! Reviews applied: [51052] Passed command: expo

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-09-29 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Sept. 29, 2016, 8:09 p.m.) Review request for mesos, Gilbert Song, hao

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-09-07 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Sept. 7, 2016, 4:51 p.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review147352 --- Patch looks great! Reviews applied: [51052] Passed command: expo

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Aug. 30, 2016, 5:56 p.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review147144 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (line 52

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146717 --- Patch looks great! Reviews applied: [51052] Passed command: expo

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-24 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Aug. 24, 2016, 8:32 p.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146592 --- Patch looks great! Reviews applied: [51009, 51052] Passed comman

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Aug. 22, 2016, 10:24 p.m.) Review request for mesos, Gilbert Song, hao

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146402 --- src/docker/docker.hpp (line 51)

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146391 --- src/slave/containerizer/docker.cpp (lines 173 - 178)

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146382 --- src/docker/docker.hpp (line 51)

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review145839 --- Patch looks great! Reviews applied: [51009, 51052] Passed comman

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-15 Thread Zhitao Li
> On Aug. 13, 2016, 1:02 a.m., Zhitao Li wrote: > > src/docker/docker.hpp, line 152 > > > > > > Note that this does not apply cleanly anymore, because gmock only > > generate mocks for functions with up to 10 argume

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Aug. 15, 2016, 9:21 p.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-12 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review145684 --- src/docker/docker.hpp (line 152)

Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-12 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. Bugs: MESOS