Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-25 Thread Daniel Pravat
> On Aug. 22, 2016, 6:39 p.m., Joseph Wu wrote: > > Note: Your summary/description says `execlp`, but the code is for `execvp` > > :P I will change the summary. - Daniel --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/#review146709 --- Fix it, then Ship it!

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-24 Thread Daniel Pravat
> On Aug. 22, 2016, 6:39 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/shell.hpp, lines 114-115 > > > > > > I'm not sure I understand what this comment is saying. Are you > > explaining the

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/#review146398 --- Note: Your summary/description says `execlp`, but the code is for

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/ --- (Updated Aug. 19, 2016, 5:38 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/#review146141 --- Patch looks great! Reviews applied: [51210, 51217] Passed

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-18 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/ --- (Updated Aug. 18, 2016, 6:20 p.m.) Review request for mesos, Alex Naparu,

Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-18 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph