Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-14 Thread Abhishek Dasgupta
> On Sept. 14, 2016, 12:26 a.m., Anand Mazumdar wrote: > > src/scheduler/scheduler.cpp, line 744 > > > > > > hmm, this won't quite work for the scheduler library i.e. the messages > > metric would always be 0. > >

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review148822 --- src/scheduler/scheduler.cpp (line 744)

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-09 Thread Vinod Kone
> On Sept. 8, 2016, 11:48 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, lines 373-380 > > > > > > oh i didn't mean to add a comment about what these metrics "mean". i > > meant which event is this

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-08 Thread Abhishek Dasgupta
> On Sept. 8, 2016, 11:48 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, lines 373-380 > > > > > > oh i didn't mean to add a comment about what these metrics "mean". i > > meant which event is this

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review148182 --- Patch looks great! Reviews applied: [51501] Passed command:

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review148172 --- src/tests/scheduler_tests.cpp (lines 370 - 377)

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-06 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/ --- (Updated Sept. 6, 2016, 8:53 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-06 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/ --- (Updated Sept. 6, 2016, 8:52 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-09-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review147800 --- Fix it, then Ship it! src/tests/scheduler_tests.cpp (lines

Re: Review Request 51501: Exposed metrics in scheduler library.

2016-08-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review147223 --- Patch looks great! Reviews applied: [51501] Passed command:

Review Request 51501: Exposed metrics in scheduler library.

2016-08-29 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6080