> On Sept. 8, 2016, 11:48 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, lines 373-380 > > <https://reviews.apache.org/r/51501/diff/1-2/?file=1488156#file1488156line373> > > > > oh i didn't mean to add a comment about what these metrics "mean". i > > meant which event is this exactly (e.g., is it the heartbeat event). > > Abhishek Dasgupta wrote: > Vinod, in this test there is no message event. The assertion is to > validate if `scheduler/event_queue_messages` and > `scheduler/event_queue_dispatch` is present in metrics JSON. However, in this > particular test the value for `scheduler/event_queue_dispatch` is 1.0 and > that is due to `subscribe` call. So, for `scheduler/event_queue_dispatch`, I > can write `// Dispatch event due to Subscribe call.` But for `EXPECT_EQ(1u, > metrics.values.count("scheduler/event_queue_messages"));`, there is no event > in the current test that is generating any MessageEvent. Any suggestion what > should we write as a comment for this? As I can find, heartbeat event is not > a MessageEvent. Am I missing something??
I see. This is just testing that the metric exists and not its value. Never mind them. LGTM. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review148172 ----------------------------------------------------------- On Sept. 6, 2016, 8:53 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51501/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 8:53 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6080 > https://issues.apache.org/jira/browse/MESOS-6080 > > > Repository: mesos > > > Description > ------- > > Exposed metrics scheduler/event_queue_messages(size of > message queue) and scheduler/event_queue_dispatches > (size of dispatch queue) in scheduler library. > > > Diffs > ----- > > src/scheduler/scheduler.cpp 276ed10bd439c4a7830447bec5053292fb2ca4e7 > src/tests/scheduler_tests.cpp 931c1857f1ab454c67eece2f34c4649a426178de > > Diff: https://reviews.apache.org/r/51501/diff/ > > > Testing > ------- > > On Ubuntu 16.04 > sudo GTEST_FILTER="*SchedulerTest.MetricsEndpoint*" make -j4 check > > > Thanks, > > Abhishek Dasgupta > >
