Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

2016-09-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/#review149546 --- Ship it! Ship It! - Anindya Sinha On Sept. 19, 2016, 8:48

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

2016-09-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/ --- (Updated Sept. 19, 2016, 1:48 p.m.) Review request for mesos, Anindya Sinha

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

2016-09-19 Thread Jiang Yan Xu
> On Sept. 18, 2016, 11:35 a.m., Anindya Sinha wrote: > > src/tests/reservation_endpoints_tests.cpp, line 1671 > > > > > > This test verifies the keys `reserved_resources` as well as > > `reserved_resources_full`,

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

2016-09-19 Thread Jiang Yan Xu
> On Sept. 18, 2016, 7:37 a.m., haosdent huang wrote: > > src/tests/reservation_endpoints_tests.cpp, lines 1652-1654 > > > > > > I think you `settle` here to wait for `Slave::checkpointResources` > > finished,

Re: Review Request 51870: Added a test for reservation info in the agent's endpoint.

2016-09-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/#review149369 --- src/tests/reservation_endpoints_tests.cpp (lines 1652 - 1654)

Review Request 51870: Added a test for reservation info in the agent's endpoint.

2016-09-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51870/ --- Review request for mesos, Anindya Sinha and Neil Conway. Bugs: MESOS-6085