Re: Review Request 53067: Added log message when terminating agent ID.

2017-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review167425 --- Closing this review due to inactivity. Please see our

Re: Review Request 53067: Added log message when terminating agent ID.

2016-10-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review153799 --- Patch looks great! Reviews applied: [53033, 53035, 53067]

Re: Review Request 53067: Added log message when terminating agent ID.

2016-10-24 Thread Vinod Kone
> On Oct. 24, 2016, 5:21 p.m., Neil Conway wrote: > > src/slave/slave.cpp, line 787 > > > > > > I wanted to avoid using "terminating" because that describes a > > particular state in the agent's state machine; the

Re: Review Request 53067: Added log message when terminating agent ID.

2016-10-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review153709 --- src/slave/slave.cpp (line 787)

Re: Review Request 53067: Added log message when terminating agent ID.

2016-10-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/ --- (Updated Oct. 24, 2016, 5:20 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53067: Added log message when terminating agent ID.

2016-10-24 Thread Neil Conway
> On Oct. 21, 2016, 9:37 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 821 > > > > > > s/agent ID/agent/ If we say "Terminating agent 123; agent will register and obtain a new agent ID the next time it is

Re: Review Request 53067: Added log message when terminating agent ID.

2016-10-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review153602 --- src/slave/slave.cpp (lines 815 - 819)

Re: Review Request 53067: Added log message when terminating agent ID.

2016-10-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review153458 --- Patch looks great! Reviews applied: [53033, 53035, 53067]

Review Request 53067: Added log message when terminating agent ID.

2016-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/ --- Review request for mesos and Vinod Kone. Repository: mesos Description