Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review162752 --- Ship it! Ship It! - Vinod Kone On Jan. 24, 2017, 12:54

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 24, 2017, 12:54 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review162736 --- src/master/master.cpp (lines 5591 - 5598)

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 18, 2017, 7:33 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 17, 2017, 6:37 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 12, 2017, 10:55 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review161152 --- src/master/master.cpp (lines 5689 - 5728)

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-10 Thread Vinod Kone
> On Jan. 3, 2017, 10:51 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 5512 > > > > > > inline this? > > Neil Conway wrote: > To me, using a separate function was more readable than writing the logic

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-10 Thread Neil Conway
> On Jan. 3, 2017, 10:51 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 5512 > > > > > > inline this? To me, using a separate function was more readable than writing the logic inline. Happy to change it

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 10, 2017, 10:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 10, 2017, 2:29 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2017-01-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review160439 --- src/master/master.cpp (line 5512)

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2016-12-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review157710 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2016-12-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Dec. 2, 2016, 12:25 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review157535 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2016-11-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6602