Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated March 15, 2017, 12:46 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review168974 --- Ship it! Ship It! - Vinod Kone On March 14, 2017, 2:05

Re: Review Request 56208: Updated checks library with general check support.

> On March 1, 2017, 8:23 p.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Line 424 (original), 440 (patched) > > > > > > why are we sending WEXITSTATUS and not exit code? > > Alexander Rukletsov wrote: >

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated March 14, 2017, 2:05 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

> On March 1, 2017, 8:23 p.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Line 424 (original), 440 (patched) > > > > > > why are we sending WEXITSTATUS and not exit code? > > Alexander Rukletsov wrote: >

Re: Review Request 56208: Updated checks library with general check support.

> On March 1, 2017, 8:23 p.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Line 424 (original), 440 (patched) > > > > > > why are we sending WEXITSTATUS and not exit code? > > Alexander Rukletsov wrote: >

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated March 7, 2017, 8:39 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

> On March 1, 2017, 8:23 p.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Line 424 (original), 440 (patched) > > > > > > why are we sending WEXITSTATUS and not exit code? Because what we get from

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review167557 --- src/checks/checker.cpp Line 297 (original), 309 (patched)

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated March 1, 2017, 12:50 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated Feb. 28, 2017, 3:50 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated Feb. 28, 2017, 3:49 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

> On Feb. 14, 2017, 5:46 p.m., Gastón Kleiman wrote: > > src/checks/checker.cpp, line 219 > > > > > > I think that it'd be useful to log the `taskId` here, since an executor > > might have multiple checkers running

Re: Review Request 56208: Updated checks library with general check support.

> On Feb. 14, 2017, 5:46 p.m., Gastón Kleiman wrote: > > src/checks/checker.cpp, line 219 > > > > > > I think that it'd be useful to log the `taskId` here, since an executor > > might have multiple checkers running

Re: Review Request 56208: Updated checks library with general check support.

> On Feb. 14, 2017, 5:46 p.m., Gastón Kleiman wrote: > > src/checks/checker.cpp, line 219 > > > > > > I think that it'd be useful to log the `taskId` here, since an executor > > might have multiple checkers running

Re: Review Request 56208: Updated checks library with general check support.

> On Feb. 14, 2017, 5:46 p.m., Gastón Kleiman wrote: > > Many of the comments here also apply to the current code in > > `health_checker.cpp`. One possibility would be to commit this patch without > > fixing them, and then creating a new patch with the fixes for both > > `health_checker.cpp`

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated Feb. 28, 2017, 11:12 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review165521 --- Many of the comments here also apply to the current code in

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review165034 --- src/checks/checker.cpp (line 255)

Re: Review Request 56208: Updated checks library with general check support.

> On Feb. 7, 2017, 1:38 a.m., Vinod Kone wrote: > > src/checks/checker.cpp, line 273 > > > > > > is the equality operator defined for the above statement to be true? > > Alexander Rukletsov wrote: > I'm not

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated Feb. 9, 2017, 12:56 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated Feb. 8, 2017, 9:06 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review164677 --- src/checks/checker.hpp (line 70)

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated Feb. 8, 2017, 4:56 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 56208: Updated checks library with general check support.

> On Feb. 7, 2017, 1:38 a.m., Vinod Kone wrote: > > src/checks/checker.cpp, line 273 > > > > > > is the equality operator defined for the above statement to be true? I'm not sure I understand you question, but

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated Feb. 8, 2017, 3:13 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review164424 --- src/checks/checker.hpp (line 60)

Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906