Re: Review Request 56217: Added support for general checks to default executor.

2017-03-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/#review169272 --- Fix it, then Ship it! src/launcher/default_executor.cpp Lines

Re: Review Request 56217: Added support for general checks to default executor.

2017-03-16 Thread Alexander Rukletsov
> On Feb. 15, 2017, 2:32 p.m., Gastón Kleiman wrote: > > src/launcher/default_executor.cpp > > Lines 931 (patched) > > > > > > I think that it'd be useful to also log the exit status/http status > > code. > >

Re: Review Request 56217: Added support for general checks to default executor.

2017-03-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/ --- (Updated March 16, 2017, 4:45 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 56217: Added support for general checks to default executor.

2017-03-16 Thread Alexander Rukletsov
> On Feb. 15, 2017, 2:32 p.m., Gastón Kleiman wrote: > > src/launcher/default_executor.cpp > > Lines 931 (patched) > > > > > > I think that it'd be useful to also log the exit status/http status > > code. > >

Re: Review Request 56217: Added support for general checks to default executor.

2017-02-15 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/#review165698 --- src/launcher/default_executor.cpp (line 93)

Re: Review Request 56217: Added support for general checks to default executor.

2017-02-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/ --- (Updated Feb. 8, 2017, 4:57 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 56217: Added support for general checks to default executor.

2017-02-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/ --- (Updated Feb. 8, 2017, 3:22 p.m.) Review request for mesos, Gastón Kleiman and

Review Request 56217: Added support for general checks to default executor.

2017-02-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906