Re: Review Request 56524: Added `drop` for overload to avoid custom logging.

2017-02-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56524/#review165225 --- Fix it, then Ship it! src/master/master.cpp (line 3278)

Re: Review Request 56524: Added `drop` for overload to avoid custom logging.

2017-02-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56524/ --- (Updated 二月 11, 2017, 1:02 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 56524: Added `drop` for overload to avoid custom logging.

2017-02-10 Thread Guangya Liu
> On 二月 10, 2017, 9:27 p.m., Benjamin Mahler wrote: > > src/master/master.cpp, lines 2246-2247 > > > > > > Can you follow the same format at the drop two lines above? > > > > ``` > > LOG(ERROR) << "Dr

Re: Review Request 56524: Added `drop` for overload to avoid custom logging.

2017-02-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56524/#review165176 --- src/master/master.cpp (lines 2246 - 2247)

Re: Review Request 56524: Added `drop` for overload to avoid custom logging.

2017-02-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56524/#review165064 --- Patch looks great! Reviews applied: [56499, 56524] Passed comman

Review Request 56524: Added `drop` for overload to avoid custom logging.

2017-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56524/ --- Review request for mesos, Benjamin Mahler and Jay Guo. Bugs: MESOS-6638 htt