Re: Review Request 57340: Remove adjustment code within Resources::apply.

2017-03-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/#review169209 --- Ship it! Ship It! - Benjamin Mahler On March 15, 2017, 3:26

Re: Review Request 57340: Remove adjustment code within Resources::apply.

2017-03-14 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/ --- (Updated March 15, 2017, 11:26 a.m.) Review request for mesos and Benjamin

Re: Review Request 57340: Remove adjustment code within Resources::apply.

2017-03-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/#review168954 --- Patch looks great! Reviews applied: [57340] Passed command:

Re: Review Request 57340: Remove adjustment code within Resources::apply.

2017-03-14 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/ --- (Updated March 15, 2017, 1:39 a.m.) Review request for mesos and Benjamin

Re: Review Request 57340: Remove adjustment code within Resources::apply.

2017-03-14 Thread Jay Guo
> On March 14, 2017, 7:03 a.m., Benjamin Mahler wrote: > > Looks good, the changes to resources.cpp were done how? Are they a direct > > reversion to the old code? Yes, I did a `git revert` and apply changes based on that. > On March 14, 2017, 7:03 a.m., Benjamin Mahler wrote: > >

Re: Review Request 57340: Remove adjustment code within Resources::apply.

2017-03-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/#review168539 --- Looks good, the changes to resources.cpp were done how? Are they

Review Request 57340: Remove adjustment code within Resources::apply.

2017-03-06 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7048