Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/#review173166 --- Ship it! Ship It! - Adam B On April 11, 2017, 3:58 a.m.,

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 11, 2017, 12:58 p.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-11 Thread Alexander Rojas
> On April 11, 2017, 8:21 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp > > Line 458 (original), 405 (patched) > > > > > > Why isn't this a `return Error();` too? Originally we used the `UNKNOWN` in

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 11, 2017, 1:48 a.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/#review171392 --- Minor comments, but it looks pretty close to shippable to me.

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 10, 2017, 12:11 p.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/#review171379 --- src/authorizer/local/authorizer.cpp Lines 401 (patched)

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-04-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 4, 2017, 11:21 a.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-03-17 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated March 17, 2017, 12:54 p.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-03-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/#review169123 --- Could you rebase this onto a current `HEAD`? - Benjamin Bannier

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-03-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated March 13, 2017, 2:21 p.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-03-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated March 13, 2017, 2:14 p.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-03-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/#review168590 --- src/authorizer/local/authorizer.cpp Lines 423 (patched)

Re: Review Request 57473: Added support for authorization of Hierachical roles.

2017-03-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated March 10, 2017, 9:18 a.m.) Review request for mesos, Adam B and

Review Request 57473: Added support for authorization of Hierachical roles.

2017-03-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- Review request for mesos, Adam B and Benjamin Bannier. Repository: mesos