Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 31, 2017, 9:24 p.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 214-217 (original), 215-216 (patched) > > > > > > A TODO to consolidate this into the client struct

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/ --- (Updated March 31, 2017, 9:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/#review170780 --- Ship it! src/master/allocator/sorter/drf/sorter.hpp Lines

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 29, 2017, 10:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 214-216 (original), 215-217 (patched) > > > > > > This comment is no longer accurate, right? We used

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/ --- (Updated March 31, 2017, 8:15 p.m.) Review request for mesos, Benjamin

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/#review170754 --- Fix it, then Ship it!

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 29, 2017, 10:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 214-216 (original), 215-217 (patched) > > > > > > This comment is no longer accurate, right? We used

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/ --- (Updated March 30, 2017, 5:58 p.m.) Review request for mesos, Benjamin

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 29, 2017, 10:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 214-216 (original), 215-217 (patched) > > > > > > This comment is no longer accurate, right? We used

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/#review170491 --- src/master/allocator/sorter/drf/sorter.hpp Lines 214-216

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 17, 2017, 1:33 a.m., Benjamin Mahler wrote: > > Hm.. this seems to introduce a performance regression in the case where > > there are many inactive roles in the system? I assume it's difficult to > > avoid in the hierarchical case? Otherwise, this looks good. > > Neil Conway wrote:

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 17, 2017, 1:33 a.m., Benjamin Mahler wrote: > > Hm.. this seems to introduce a performance regression in the case where > > there are many inactive roles in the system? I assume it's difficult to > > avoid in the hierarchical case? Otherwise, this looks good. True -- if there are

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/#review169245 --- Hm.. this seems to introduce a performance regression in the case

Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.