Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Joseph Wu
> On March 29, 2017, 12:30 p.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 38 (patched) > > > > > > Are we going to enable verbose Cotire logging? It's useful. > > Andrew

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Andrew Schwartzmeyer
> On March 29, 2017, 7:30 p.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 38 (patched) > > > > > > Are we going to enable verbose Cotire logging? It's useful. (Or note for users that

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Andrew Schwartzmeyer
> On March 29, 2017, 6:54 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 39-40 (patched) > > > > > > I'll add a comment explaining unity builds: > > ``` > > # By default Cotire

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Joseph Wu
> On March 29, 2017, 11:54 a.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 34-36 (patched) > > > > > > I think we can remove this check, as it would block people that want to > > fix the

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/#review170448 --- src/CMakeLists.txt Lines 545 (patched)

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Andrew Schwartzmeyer
> On March 29, 2017, 6:54 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 32 (patched) > > > > > > You need to surround `WIN32` with `${}`. Otherwise, this will default > > to `OFF` on

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/#review170451 --- cmake/CompilationConfigure.cmake Lines 33 (patched)

Re: Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/#review170445 --- Fix it, then Ship it! Only minor issues, so I'll tweak them

Review Request 58014: CMake: Setup cotire for 'mesos-agent' target.

2017-03-28 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58014/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li