Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/#review172687 --- Ship it! Ship It! - Vinod Kone On April 19, 2017, 6:48

Re: Review Request 58428: Added tests for failed executor authorization.

> On April 19, 2017, 12:33 a.m., Vinod Kone wrote: > > src/tests/slave_authorization_tests.cpp > > Lines 1070 (patched) > > > > > > don't need terminate/wait slave here like the above test? Nope, this test uses

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/ --- (Updated April 19, 2017, 6:48 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58428: Added tests for failed executor authorization.

> On April 19, 2017, 12:33 a.m., Vinod Kone wrote: > > While these tests are good I'm wondering if they are realistic, because the > > assumption is that someone knows the agent's secret key but doesn't know > > the container id of the executor they want to attack. In reality it's the > >

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/#review172293 --- Fix it, then Ship it! While these tests are good I'm wondering

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/ --- (Updated April 14, 2017, 9:18 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/ --- (Updated April 14, 2017, 9:16 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/#review171942 --- Patch looks great! Reviews applied: [58327, 58328, 58251, 58252,

Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7339