Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/#review174988 --- Fix it, then Ship it! I can fix this up before committing.

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- (Updated May 2, 2017, 9:46 p.m.) Review request for mesos, Andrew

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- (Updated May 1, 2017, 9:01 p.m.) Review request for mesos, Andrew

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Line 96 (original), 96 (patched) > > > > > > There are more instances of erroneous absolute path

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- (Updated April 28, 2017, 9:43 p.m.) Review request for mesos, Andrew

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 92-108 (patched) > > > > > > I'm hoping Joe approves of this style; it's what I came up with while > >

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Line 96 (original), 96 (patched) > > > > > > There are more instances of erroneous absolute path

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 4:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Line 96 (original), 96 (patched) > > > > > > There are more instances of erroneous absolute path

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/#review173240 --- Patch looks great! Reviews applied: [58673] Passed command:

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 79-86 (patched) > > > > > > I think this got a bit out of date. We settled on `\...` being an > >

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 79-86 (patched) > > > > > > I think this got a bit out of date. We settled on `\...` being an > >

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/#review173000 --- 3rdparty/stout/include/stout/flags/parse.hpp Line 96 (original),

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- (Updated April 25, 2017, 6:24 p.m.) Review request for mesos, Andrew

Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li