Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/ --- (Updated May 3, 2017, 6:23 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

> On May 2, 2017, 9:13 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/version.hpp > > Lines 102 (patched) > > > > > > I guess this breaks for the negative case? E.g. 1.0.0--1.-1 > > > > We'll

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/ --- (Updated May 3, 2017, 5:30 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/#review173649 --- Fix it, then Ship it!

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

> On April 26, 2017, 11:16 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/version.hpp > > Lines 156-157 (patched) > > > > > > In general we try to open and close the quote on the same line if > >

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/ --- (Updated May 2, 2017, 8 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

> On April 26, 2017, 11:16 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/version.hpp > > Lines 51-54 (original), 60-63 (patched) > > > > > > I wasn't able to see how "raw" describes what this is

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/ --- (Updated May 1, 2017, 11:45 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

> On April 26, 2017, 11:16 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/version.hpp > > Lines 66-71 (original), 139-182 (patched) > > > > > > These are made public but I can't see how these would be

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/#review172994 --- Really happy to see these patches! At a high level the main

Re: Review Request 58707: Enhanced stout's Version to support prerelease and build labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58707/ --- (Updated April 26, 2017, 5:35 p.m.) Review request for mesos, Benjamin Mahler