Re: Review Request 60482: Defined Git variables in CMake configure file.

2017-07-17 Thread Andrew Schwartzmeyer
> On July 17, 2017, 10:18 a.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 347-348 (original), 367-368 (patched) > > > > > > This comment should be updated to reflect the doubling in output. +1

Re: Review Request 60482: Defined Git variables in CMake configure file.

2017-07-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60482/#review180706 --- Patch looks great! Reviews applied: [60482] Passed command: supp

Re: Review Request 60482: Defined Git variables in CMake configure file.

2017-07-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60482/#review180697 --- Ship it! Going to add some more comments and whitespace before

Review Request 60482: Defined Git variables in CMake configure file.

2017-06-27 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60482/ --- Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph W