Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review180464 --- We try to include the commit message when marking as submitted,

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review180418 --- Ship it! - Alexander Rojas On July 11, 2017, 11:24 a.m.,

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review180417 --- Patch looks great! Reviews applied: [60704, 60598] Passed

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review180271 --- Bad patch! Reviews applied: [60598, 60704] Failed command:

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-10 Thread Andrei Budnik
> On July 10, 2017, 2:19 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/subprocess.cpp > > Line 118 (original), 118 (patched) > > > > > > Here and below, we use the macro `EXIT(EXIT_FAILURE)` with a log

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review180034 --- 3rdparty/libprocess/src/subprocess.cpp Line 118 (original), 118

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review179867 --- Ship it! - Benjamin Bannier On July 3, 2017, 4:58 p.m.,

Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.

2017-07-07 Thread Andrei Budnik
> On July 5, 2017, 4:29 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/subprocess.cpp > > Lines 176 (patched) > > > > > > Any reason we cannot do a proper `exit` here? > > > > Here and below. 1.

Re: Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.

2017-07-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review179730 --- Bad patch! Reviews applied: [60598] Failed command: python

Re: Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.

2017-07-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review179643 --- 3rdparty/libprocess/src/subprocess.cpp Lines 172-173 (original),

Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.

2017-07-03 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and James Peach.