Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-10-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review187358 --- Summary and description need to follow Mesos standards

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated Oct. 6, 2017, 4:04 a.m.) Review request for mesos, Andrew

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-24 Thread Jeff Coffler
> On Aug. 16, 2017, 12:19 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 70 (patched) > > > > > > Should be an `#ifdef`. I took care of this since I'm re-working the commits. > On

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review180778 --- Ship it! I'll fix this up before committing the chain.

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-15 Thread Andrew Schwartzmeyer
> On Aug. 15, 2017, 10:47 a.m., Andrew Schwartzmeyer wrote: > > Ship It! You can remove the "depends on 60345" here to make the bot a bit happier. - Andrew --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-15 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review182962 --- Ship it! Ship It! - Andrew Schwartzmeyer On July 5, 2017,

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-07-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated July 5, 2017, 5:43 p.m.) Review request for mesos, Andrew

Review Request 60620: Modify os::write to write binary files on Windows.

2017-07-03 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li