Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

2017-10-13 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188011 --- 3rdparty/stout/include/stout/path.hpp Lines 28-46 (patched)

Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

2017-10-12 Thread Jeff Coffler
> On Oct. 8, 2017, 3:33 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/uri.hpp > > Lines 33 (patched) > > > > > > Also, the casing comment applies to the funciton name too, plus the > > double

Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

2017-10-12 Thread Jeff Coffler
> On Oct. 8, 2017, 3:27 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 28-35 (patched) > > > > > > General note on comment style: Mesos / stout / libprocess uses `//` > > over

Re: Review Request 60622: Added new stout functions for path normalizaiton and URI conversion.

2017-10-11 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 11, 2017, 11:31 p.m.) Review request for mesos, Andrew