Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review193295 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-12-07 Thread Jeff Coffler
> On Nov. 16, 2017, 11:34 p.m., Jie Yu wrote: > > src/hdfs/hdfs.cpp > > Line 119 (original), 119 (patched) > > > > > > i'd kill this line to be consistent with others. I don't think you're looking at the latest

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-12-07 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Dec. 8, 2017, 2:44 a.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-11-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review191269 --- Fix it, then Ship it! src/hdfs/hdfs.cpp Line 119 (original),

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-19 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review188763 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 19, 2017,

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 19, 2017, 6:17 p.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-19 Thread Jeff Coffler
> On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote: > > Needs a description still. Ok. > On Oct. 18, 2017, 12:45 a.m., Andrew Schwartzmeyer wrote: > > src/hdfs/hdfs.cpp > > Lines 125-134 (patched) > > > > > >

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-17 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review188428 --- Needs a description still. src/hdfs/hdfs.cpp Lines 125-134

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-16 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 17, 2017, 1:19 a.m.) Review request for mesos, Andrew

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-12 Thread Jeff Coffler
> On Oct. 8, 2017, 4:16 a.m., Andrew Schwartzmeyer wrote: > > src/hdfs/hdfs.cpp > > Lines 117-118 (original), 117-118 (patched) > > > > > > I believe that [this > >

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-10-11 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- (Updated Oct. 11, 2017, 11:31 p.m.) Review request for mesos, Andrew