Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60720/#review180249 --- Will addressing the changes suggested by Yan in a separate patch,

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-10 Thread Avinash sridharan
> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 1135 (original), 1135 (patched) > > > > > > You are (re)initalizing/resetting this `__address__` but not > >

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-10 Thread Jiang Yan Xu
> On July 7, 2017, 4:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 1135 (original), 1135 (patched) > > > > > > You are (re)initalizing/resetting this `__address__` but not > >

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-07 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60720/ --- (Updated July 8, 2017, 12:08 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-07 Thread Avinash sridharan
> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 1191 (original), 1192 (patched) > > > > > > Should `advertise_ip` be treated the same way as `ip`? i.e., flag > >

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-07 Thread Avinash sridharan
> On July 7, 2017, 11:18 p.m., Jiang Yan Xu wrote: > > Could you fill out the 'testing done' section? I know there will be a > > follow up test patch but for this at least `make check` and manual > > verification? > > Jiang Yan Xu wrote: > I committed it but could you respond to the

Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60720/#review179958 --- Fix it, then Ship it! Could you fill out the 'testing done'

Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.

2017-07-07 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60720/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7769