Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201662 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 20, 2018,

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 20, 2018, 10:18 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 20, 2018, 9:51 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 20, 2018, 9:22 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201623 --- This does currently not configure for me with `ENABLE_GRPC` (for t

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 20, 2018, 2:28 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61096: Building gRPC with CMake.

> On April 18, 2018, 6:57 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 1001 (patched) > > > > > > I see `gpr` in here which looks like a typo for `grp`? No. It's GPR, a library used in gr

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201443 --- 3rdparty/CMakeLists.txt Lines 1001 (patched)

Re: Review Request 61096: Building gRPC with CMake.

> On April 12, 2018, 9:41 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 1012-1015 (patched) > > > > > > As stated above, the probably won't work on Windows yet. Ths VS > > solutions genera

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 17, 2018, 3:16 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61096: Building gRPC with CMake.

> On April 12, 2018, 4:41 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Line 143 (original), 144-145 (patched) > > > > > > Seems reasonable. Could alternatively setup `ENABLE_GRPC` to set > > `EN

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201007 --- I want to test on Windows and see if we can get it building there

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated April 12, 2018, 3:22 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated March 19, 2018, 11:50 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated Aug. 5, 2017, 2:08 a.m.) Review request for mesos, Andrew Schwartzmeye

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated Aug. 4, 2017, 11:20 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated Aug. 4, 2017, 1:17 a.m.) Review request for mesos, Andrew Schwartzmeye