Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-06 Thread Avinash sridharan
> On Sept. 6, 2017, 2:09 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > > Lines 149 (patched) > > > > > > Why are we setting this empty

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184625 --- Bad patch! Reviews applied: [62017] Failed command: python

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Deepak Goel
> On Sept. 6, 2017, 2:09 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > > Lines 149 (patched) > > > > > > Why are we setting this empty

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184621 --- FAIL: Mesos tests failed to run Reviews applied: [62017] Logs

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184620 ---

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Deepak Goel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/ --- (Updated Sept. 6, 2017, 12:25 a.m.) Review request for mesos and Avinash

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184604 --- FAIL: Mesos tests failed to run Reviews applied: [62017] Logs

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184603 --- Fix it, then Ship it!

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-05 Thread Deepak Goel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/ --- (Updated Sept. 5, 2017, 9:47 p.m.) Review request for mesos and Avinash

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184507 ---

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184468 ---

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-09-01 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184405 --- @Deepak, in the description, I see you mentioned: > However, in

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-08-31 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184310 --- Patch looks great! Reviews applied: [62017] Passed command:

Re: Review Request 62017: Allows port mapper plugin to have optional args.

2017-08-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184307 --- Patch looks great! Reviews applied: [62017] Logs available

Review Request 62017: Allows port mapper plugin to have optional args.

2017-08-31 Thread Deepak Goel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/ --- Review request for mesos and Avinash sridharan. Bugs: mesos-7923