Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186924 --- PASS: Mesos patch 62353 was successfully built and tested.

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Oct. 2, 2017, 11:13 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186879 --- Patch looks great! Reviews applied: [62655, 62158, 61183, 61528,

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186876 --- FAIL: Mesos tests failed to build. Reviews applied: `['62655',

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186165 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 25, 2017, 9:42 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186101 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 25, 2017, 12:27 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186048 --- Fix it, then Ship it!

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186016 --- Patch looks great! Reviews applied: [62282, 58048, 62158, 62438,

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185993 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

> On Sept. 22, 2017, 2:29 a.m., Jie Yu wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 408 (patched) > > > > > > This does not build on WINDOWS. I suggest we use in memory storage so > > that we

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 22, 2017, 5:03 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185939 --- src/resource_provider/registrar.cpp Lines 397 (patched)

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185925 --- FAIL: Failed to apply the dependent review: 62282. Failed

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 21, 2017, 9 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185890 --- FAIL: Mesos tests failed to build. Reviews applied: `['62282',

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

> On Sept. 20, 2017, 9:36 p.m., Jie Yu wrote: > > src/resource_provider/registrar.hpp > > Lines 133 (patched) > > > > > > No need for `explicit` because this is a two arguments constructor I made this a one-arg

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 21, 2017, 2:59 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185860 --- Patch looks great! Reviews applied: [62282, 58048, 62158, 62438,

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185695 --- src/master/registry.proto Lines 116 (patched)

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185713 --- FAIL: The file

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- (Updated Sept. 19, 2017, 6:54 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185509 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review185483 --- Bad review! Error: No reviewers specified. Please find a

Review Request 62353: Added a master-registry backed resource provider manager registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/ --- Review request for mesos. Repository: mesos Description --- This patch