Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-10 Thread Till Toenshoff
> On Oct. 10, 2017, 5:49 a.m., Greg Mann wrote: > > src/scheduler/scheduler.cpp > > Lines 312-318 (patched) > > > > > > So, this means the basic HTTP authenticatee is loaded and called into > > when the user

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-10 Thread Till Toenshoff
> On Oct. 10, 2017, 5:24 a.m., Greg Mann wrote: > > src/scheduler/flags.hpp > > Lines 53 (patched) > > > > > > I checked a few places in the master flags, and in that file we advise > > users to load modules via the

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review187497 --- src/scheduler/scheduler.cpp Lines 312-318 (patched)

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review187493 --- Fix it, then Ship it! src/scheduler/flags.hpp Lines 53

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review187325 --- src/scheduler/flags.hpp Lines 22-25 (patched)

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review187254 --- src/scheduler/scheduler.cpp Line 257 (original), 269 (patched)

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-06 Thread Alexander Rojas
> On Sept. 28, 2017, 12:07 a.m., Greg Mann wrote: > > src/scheduler/scheduler.cpp > > Line 527 (original), 594 (patched) > > > > > > Hmmm... is this CHECK correct? Since this continuation is registered as > > an

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-02 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/ --- (Updated Oct. 2, 2017, 10:29 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-02 Thread Till Toenshoff
> On Sept. 27, 2017, 10:07 p.m., Greg Mann wrote: > > src/scheduler/flags.hpp > > Lines 57-59 (patched) > > > > > > s/kept in in sync/kept in sync/ > > > > Also, this seems bad :) (also for modules_dir) I

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-02 Thread Till Toenshoff
> On Sept. 27, 2017, 10:07 p.m., Greg Mann wrote: > > src/scheduler/flags.hpp > > Lines 57-59 (patched) > > > > > > s/kept in in sync/kept in sync/ > > > > Also, this seems bad :) (also for modules_dir) I

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-09-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review186483 --- src/scheduler/flags.hpp Lines 57-59 (patched)

Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-09-26 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/ --- Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier,