Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-10-12 Thread James Peach
> On Oct. 4, 2017, 9:26 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/open.hpp > > Lines 26 (patched) > > > > > > I believe we should update the minimal Linux kernel requirements in the > >

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-10-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review187074 --- Fix it, then Ship it!

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-10-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186954 --- Ship it! Ship It! - Jie Yu On Sept. 27, 2017, 10:20 p.m.,

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-09-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186703 --- Patch looks great! Reviews applied: [62638] Passed command:

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186609 --- PASS: Mesos patch 62638 was successfully built and tested.

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-09-27 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186517 --- PASS: Mesos patch 62638 was successfully built and tested.

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-09-27 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review186506 --- Ship it! Looks good to me, just waiting on the Windows

Review Request 62638: Removed support for platforms without O_CLOEXEC.

2017-09-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/ --- Review request for mesos, Andrew Schwartzmeyer and Jie Yu. Bugs: MESOS-8027