Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

2017-11-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Nov. 28, 2017, 12:56 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

2017-11-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Nov. 22, 2017, 5:19 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

2017-11-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Nov. 21, 2017, 7:55 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.

2017-10-27 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Oct. 27, 2017, 11:58 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63060: Added utility functions and structures for CSI.

2017-10-19 Thread Chun-Hung Hsiao
> On Oct. 19, 2017, 5:51 p.m., Jie Yu wrote: > > src/csi/utils.cpp > > Lines 25 (patched) > > > > > > Do you need `csi::` prefix? Yes. `Version` is also defined in stout. - Chun-Hung

Re: Review Request 63060: Added utility functions and structures for CSI.

2017-10-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/#review188712 --- Fix it, then Ship it! src/csi/utils.hpp Lines 77-78 (patched)

Re: Review Request 63060: Added utility functions and structures for CSI.

2017-10-16 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63060/ --- (Updated Oct. 17, 2017, 4:50 a.m.) Review request for mesos and Jie Yu.