Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-12-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192534 --- Lets split this review into 2 1) `updateSlave()` should take Slav

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-12-01 Thread Vinod Kone
> On Dec. 1, 2017, 12:24 p.m., Benjamin Bannier wrote: > > include/mesos/allocator/allocator.hpp > > Lines 211-212 (patched) > > > > > > This doesn't look what was in the original design where a framework > > could

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-12-01 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Dec. 1, 2017, 6:31 p.m.) Review request for mesos and Vinod Kone. Re

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-12-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192478 --- include/mesos/allocator/allocator.hpp Lines 211-212 (patched)

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-11-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192147 --- Ship it! Ship It! - Vinod Kone On Nov. 29, 2017, 6:17 p.m.,

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-11-29 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Nov. 29, 2017, 6:17 p.m.) Review request for mesos and Vinod Kone. S