Re: Review Request 64879: Updated fetcher cache tests for the default executor.

2018-01-04 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64879/#review194806 --- Ship it! Ship It! - Gaston Kleiman On Dec. 30, 2017, 12:06

Re: Review Request 64879: Updated fetcher cache tests for the default executor.

2018-01-04 Thread James Peach
> On Jan. 2, 2018, 7:23 p.m., Gaston Kleiman wrote: > > src/tests/fetcher_cache_tests.cpp > > Lines 391-393 (original), 393-399 (patched) > > > > > > Can't we just do `return os::access(path, X_OK);` here? Good

Re: Review Request 64879: Updated fetcher cache tests for the default executor.

2018-01-02 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64879/#review194603 --- src/tests/fetcher_cache_tests.cpp Lines 391-393 (original),

Review Request 64879: Updated fetcher cache tests for the default executor.

2017-12-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64879/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Jie Yu.